Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching API needs better documentation #786

Open
denisrosset opened this issue Apr 3, 2019 · 0 comments
Open

Searching API needs better documentation #786

denisrosset opened this issue Apr 3, 2019 · 0 comments
Labels
good first issue

Comments

@denisrosset
Copy link
Collaborator

We state

  /** Performs a binary search, returns an index using the same convention as java.util.Arrays.binarySearch. */
final def search[@sp A: Order](as: Array[A], item: A, lower: Int, upper: Int): Int = {

However, our convention is to search the interval [lower, upper] inclusive, whereas java.util.Arrays.binarySearch excludes the upper bound.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
Typelevel Good First Issues
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@denisrosset @larsrh