Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error where zero sources are up over the horizon #13

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

tyler-a-cox
Copy link
Owner

finufft complains if the source vector has zero elements, which can happen if all sources are below the horizon. This PR skips finufft if the number of sources above the horizon is zero.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.91%. Comparing base (5c189c9) to head (c8ebb09).

Files Patch % Lines
fftvis/simulate.py 0.00% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   95.93%   92.91%   -3.03%     
==========================================
  Files           4        4              
  Lines         123      127       +4     
  Branches       33       35       +2     
==========================================
  Hits          118      118              
- Misses          3        5       +2     
- Partials        2        4       +2     
Flag Coverage Δ
unittests 92.91% <0.00%> (-3.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyler-a-cox tyler-a-cox merged commit b9229f3 into main Apr 18, 2024
9 checks passed
@tyler-a-cox tyler-a-cox deleted the fix_zero_sources_error branch April 18, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants