Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes do not credit contributors #3125

Closed
twpayne opened this issue Jul 28, 2023 · 3 comments · Fixed by #3173
Closed

Release notes do not credit contributors #3125

twpayne opened this issue Jul 28, 2023 · 3 comments · Fixed by #3173
Labels
bug Something isn't working

Comments

@twpayne
Copy link
Owner

twpayne commented Jul 28, 2023

Describe the bug

A bunch of people contribute to chezmoi. The release notes do not show these contributions. For example:

To reproduce

Get some excellent contributions and then create a new release.

Expected behavior

Contributors should be properly credited.

Output of command with the --verbose flag

n/a

Output of chezmoi doctor

n/a

Additional context

I'm rebasing commits when merging PRs, but this should not affect anything.

@twpayne twpayne added the bug Something isn't working label Jul 28, 2023
@twpayne
Copy link
Owner Author

twpayne commented Jul 28, 2023

Furthermore, it's not just the contributors that aren't getting credited. The whole PR/commit goes missing.

For example, chezmoi 2.36.0 includes support for Azure Key Vault secrets from #3112, but this is not visible in the release notes.

@bradenhilton
Copy link
Collaborator

For info, the latest release with contribution credits seems to be v2.34.3.

@bradenhilton
Copy link
Collaborator

Could github-native be partly responsible here?

It also seems to credit based on PR author instead of commit author when it works correctly, which seems incorrect to me.

I'm not sure if git{hub} would be any better.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants