Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hr-between-versions.rst template #646

Open
adiroiban opened this issue Aug 2, 2024 · 3 comments
Open

Remove hr-between-versions.rst template #646

adiroiban opened this issue Aug 2, 2024 · 3 comments

Comments

@adiroiban
Copy link
Member

I see that it was introduced in towncrier 19.9.0 in #162

but there are no tests for it.

I think that is best to remove it to simplify our code.

If anyone is using it, they can copy it to they custom path.

It's hard to support multiple template formats.

The default MD and RST should be enough.

@adiroiban
Copy link
Member Author

@hynek I see that the template was mentioned as it was added for attrs , but I see that attrs now used a custom MD template.

I think that we are good to remove the template.

@adiroiban
Copy link
Member Author

Maybe also remove single-file-no-bullets.rst

There are tests for it. I did a search of GitHub and I can't find anyone else using it... I am aware that GitHub public repos are not the whole universe :)

https://github.com/search?q=towncrier%3Asingle-file-no-bullets&type=code

The goal is to simplify the maintance of the project, having to care about fewer templates

@hynek
Copy link
Member

hynek commented Aug 3, 2024

Agreed, you can add something like “if you need them, get them from the repo” with a link to a previous tag.

most likely, they don’t work anymore anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants