Vertical toolbar background missing in last release (0.19)

[ren2r]

After update to the last release I noticed the background of the toolbar of the theme KVMojave or others that have background was missing when using the toolbar placed vertically.
I couldn't find if that was intended change, so I didn't reported it as issue without asking it first.

Here is a screenshot of how it looks now (version 0.19).

Here is a screenshot after doing a downgrade to version 0.18.0

Using a up to date archlinux system.

[ren2r]

I searched a bit and found the commit 3e40664, I guess it was when the option was removed.
May I ask to have a option for enable it in settings or maybe another way to style vertical toolbar too from inside the config file throught another section (eg. [VerticalToolbar])?

[tsujan]

Yes, the backgrounds of vertical toolbars were removed intentionally because they could look very unnatural under certain circumstances, e.g., when toolbar buttons were wide or when there were both vertical and horizontal toolbars.

I didn't add a key for it because I didn't want too many keys. However, I removed a few redundant keys; so, I can add no_vertical_toolbar with true as its default value.

[ren2r]

I undestand, it makes total sense to do this way.
I was just caught a litle by surprise because was making a custom theme based on kvmojave targeting vertical toolbar, as the screenshot bellow

And a option would be good enough.
Apreciate your effort, thanks very much for this great software.

[tsujan]

I'll add a key for it to Kvantum and also a checkbox to Kvantum Manager soon.

[ren2r]

Thanks for your attention, just one last thought ...
wouldn't the no_vertical_toolbar key be kind of confusing? (leading the user to think that vertical toolbar would be disabled)
maybe something like style_vertical_toolbar set to false would be a bit more clearer.
By the way, Thanks so much one more time.

[tsujan]

wouldn't the no_vertical_toolbar key be kind of confusing?

Yes, it is :) Here, I'd changed it to style_vertical_toolbars with a false value by default. Should add it to the doc and do some tests. Will tell you when it's ready.

Thanks for the suggestion!

[tsujan]

Done in 3b979ad

This screenshot shows the new option (belonging to "Hacks"):

Thanks again for your comments and suggestions!

[ren2r]

I just tested it and it's working perfectly.
Thank you for your effort, thank you very much