You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I found that on an embedded system if the tzdata is not installed lnav will fail in the following ways:
: command to enter the prompt will close the application
opening any logs that require time conversion will close the application as well
I've traced them to exceptions thrown by the data::tz library, and I've also tried to handle them, but since I'm not sure if this software will possibly work without such a basic data (without producing misleading results) my proposal is to just make it a definitive error and close the application. This is partially handled by catching the exception log_error("failed to setup tz: %s", e.what()); at lnav.cc but since the log file is huge it's easy to miss it. It'll be probably better to just exit and ask the user to fix its broken system.
Also the CMake recipe is missing an add_definitions(-DUSE_OS_TZDB=1 -DHAS_REMOTE_API=0) that's present in the makefile one.
Thank you for your work.
The text was updated successfully, but these errors were encountered:
lnav version
v0.12.2 is the latest
Describe the bug
I found that on an embedded system if the tzdata is not installed lnav will fail in the following ways:
:
command to enter the prompt will close the applicationI've traced them to exceptions thrown by the data::tz library, and I've also tried to handle them, but since I'm not sure if this software will possibly work without such a basic data (without producing misleading results) my proposal is to just make it a definitive error and close the application. This is partially handled by catching the exception
log_error("failed to setup tz: %s", e.what());
atlnav.cc
but since the log file is huge it's easy to miss it. It'll be probably better to just exit and ask the user to fix its broken system.Also the CMake recipe is missing an
add_definitions(-DUSE_OS_TZDB=1 -DHAS_REMOTE_API=0)
that's present in the makefile one.Thank you for your work.
The text was updated successfully, but these errors were encountered: