Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components propagating CSS properties as props #14318

Open
komret opened this issue Sep 12, 2024 · 0 comments
Open

Components propagating CSS properties as props #14318

komret opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working as expected code Code improvements components Related to global components

Comments

@komret
Copy link
Contributor

komret commented Sep 12, 2024

Some components (e.g. Button, Card) spread props and thus propagate some unintended attributes to the DOM (e.g. margin).

Please fix it to avoid the annoying warnings. Ideally, let's not use props spreading to avoid problems like this and be more explicit.

Screenshot 2024-09-12 at 16 29 36
Screenshot 2024-09-12 at 16 29 47
@komret komret added bug Something isn't working as expected components Related to global components code Code improvements labels Sep 12, 2024
This was referenced Sep 19, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected code Code improvements components Related to global components
Projects
Issues Suite
Status: 🎯 To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@komret