Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] as design pattern is deprecated on Radix-UI #218

Open
seedy opened this issue Dec 2, 2021 · 5 comments
Open

[RFC] as design pattern is deprecated on Radix-UI #218

seedy opened this issue Dec 2, 2021 · 5 comments
Assignees
@seedy
Labels
enhancement New feature or request

Comments

@seedy
Copy link
Contributor

seedy commented Dec 2, 2021 •
edited
Loading

Description

Radix deprecated as design pattern and Polymorphic in favor of asChild design pattern.

Their Slot lib component handles internal logic for the asChild pattern.

There's recommendations to reuse it, even if they deprecated it to drop support.

I think we should prepare for dropping of as design pattern and follow the asChild one.

WDYT?

https://www.radix-ui.com/docs/primitives/utilities/slot

Tasks

  • Integrate Slot component
  • Update components who could be using asChild pattern:
    • Box
    • Heading
    • Text
    • Button
    • Flex
    • Badge
    • Card
@seedy seedy changed the title as design pattern is deprecated as design pattern is deprecated on Radix-UI Dec 6, 2021
@matthieuh
Copy link
Contributor

It seems making sense 👍

@seedy seedy mentioned this issue Dec 10, 2021
Closed
@paulocfjunior
Copy link
Contributor

Yes, I agree

@paulocfjunior paulocfjunior removed their assignment Dec 15, 2021
@seedy
Copy link
Contributor Author

seedy commented Dec 15, 2021

@seedy Handle the update either by listing tasks in issue description or pushing separate issues

Then see if it can be handled quickly or not

@seedy seedy self-assigned this Jan 18, 2022
@seedy seedy added enhancement New feature or request and removed kind/proposal labels Feb 1, 2022
@seedy seedy mentioned this issue Feb 4, 2022
Closed
@seedy
Copy link
Contributor Author

seedy commented Apr 11, 2022 •
edited
Loading

Components already relying on the as behavior:

  • Badge
  • Heading
    - [ ] Box behavior makes sense
    - [ ] Text behavior makes sense
  • Button
    - [ ] Card behavior makes sense
    - [ ] Flex behavior makes sense

@seedy
Copy link
Contributor Author

seedy commented Apr 11, 2022

Related issues:

This was referenced Apr 13, 2022
Merged
Merged
@seedy seedy changed the title as design pattern is deprecated on Radix-UI [RFC] as design pattern is deprecated on Radix-UI Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seedy seedy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthieuh @seedy @paulocfjunior