Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block: Allow any AbstractDateTime #35

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpsamaroo
Copy link

Closes #34

@jpsamaroo
Copy link
Author

jpsamaroo commented Feb 27, 2022

I plan to add some tests using an ad-hoc PreciseDateTime that has nanosecond resolution.

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #35 (0f07bc1) into main (614e79b) will decrease coverage by 0.12%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   92.43%   92.30%   -0.13%     
==========================================
  Files          20       20              
  Lines        1362     1326      -36     
==========================================
- Hits         1259     1224      -35     
+ Misses        103      102       -1     
Impacted Files Coverage Δ
src/block.jl 90.36% <66.66%> (-1.31%) ⬇️
src/identity_map.jl 87.50% <0.00%> (-0.31%) ⬇️
src/graph.jl 95.12% <0.00%> (-0.23%) ⬇️
src/ops/sources.jl 92.75% <0.00%> (-0.21%) ⬇️
src/alignment.jl 92.91% <0.00%> (-0.14%) ⬇️
src/ops/align.jl 100.00% <0.00%> (ø)
src/evaluation.jl 100.00% <0.00%> (ø)
src/ops/lagging.jl 87.87% <0.00%> (+2.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614e79b...0f07bc1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block times type is too restrictive
1 participant