Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite created by field in the torrent file #285

Open
josecelano opened this issue Sep 13, 2023 · 2 comments
Open

Overwrite created by field in the torrent file #285

josecelano opened this issue Sep 13, 2023 · 2 comments
Labels
Easy Good for Newcomers Enhancement / Feature Request Something New
Milestone

Comments

@josecelano
Copy link
Member

josecelano commented Sep 13, 2023

Relates to: #284

We could overwrite the created by field in the torrent file with the value: Torrust Index/v3.0.0

Example torrent file in JSON:

{
   "created by": "imdl/0.1.13",
   "creation date": 1694545594,
   "encoding": "UTF-8",
   "info": {
      "length": 30,
      "name": "torrent-without-private-field.txt",
      "piece length": 16384,
      "pieces": "<hex>87 F9 9A 42 68 8D AE 18 E5 72 1D 7C 37 7B 88 91 E0 2D 08 9E</hex>"
   }
}
@cgbosse
Copy link
Member

cgbosse commented Jan 12, 2024

What benefit is there in this ?
Is it appropriate?
Should there be some form of traceability the creator?

@josecelano

@josecelano
Copy link
Member Author

josecelano commented Jan 12, 2024

What benefit is there in this ? Is it appropriate? Should there be some form of traceability the creator?

@josecelano

It's a matter of consistency. We can consider the Index as:

  • A simple storage for torrents without altering them. We keep the same infohash and we serve the same torrent that was uploaded.
  • An application that handles a collection of torrents. It normalizes them, so they all have similar properties and attributes.

We are doing the second because we do not store the original torrent. We only keep the standards attributes and sometimes the original infohash can change. That final one is what we call the canonical infohash. Estricitkly speaking we have created a new torrent, so the Index is the creator. It creates a new torrent by using information from a previous one.

On the other hand, just overwriting the creator could give visibility to the project. That's a "marketing" reason to do it. I would do it due to the first reason :-)

@cgbosse cgbosse added this to the v3.1.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Good for Newcomers Enhancement / Feature Request Something New
Projects
Status: Feature & Enhancement request
Development

No branches or pull requests

2 participants