Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting messages on Telegram #11

Open
x2611 opened this issue Jun 1, 2022 · 16 comments
Open

Not getting messages on Telegram #11

x2611 opened this issue Jun 1, 2022 · 16 comments
Labels
bug Something isn't working

Comments

@x2611
Copy link

x2611 commented Jun 1, 2022

Hi,

Set up bot as instructed. Made Telegram bot, added tokens, paths, IDs to config. Seems to be alright.
I get the following message after /check
If you received this message, everything is configured properly! :)

Sitting in ship at REZ, start bot, it says:
2022/06/01 13:44:36 Monitoring the journal file at C:\Users\my_name\Saved Games\Frontier Developments\Elite Dangerous\Journal.220601112123.01.log

Telegram running with bot channel open but I get no messages. 15 ships killed so far.
Tried both versions.
ED-AFK-Notifier_0.3.3_Windows_i386
ED-AFK-Notifier_0.3.3_Windows_x86_64
Win10 + ED-Horizons. (Tried with Odyssey and RunAsAdmin too. No go)
Turned on debug and it shows it's reading the log in the console.

What am I doing wrong?
Thanks

@tommyblue
Copy link
Owner

@x2611 could you paste here your configuration file (removing secret tokens)?

@x2611
Copy link
Author

x2611 commented Jun 9, 2022

[journal]
Path = "C:\Users\my_name\Saved Games\Frontier Developments\Elite Dangerous"
debug = false # Print a logline for each new line in the journal file
fighter = true # When true, send notification also for hull damage to the fighter
shields = true # When true, send a notification when shields state changes (up/down)
kills = true # When true, send notification on each new kill, including total reward earned (noisy!)
silent_kills = false # When true, reduce noise for kill notification, sending a notification every 10 kills

[telegram]
token = "1234567ID"
channelId = 1234567

@tommyblue
Copy link
Owner

strange, I need to check. Thanks

@tommyblue tommyblue added the bug Something isn't working label Jun 9, 2022
@apattillo
Copy link

For what it's worth (I know nothing about go), I was having the same problem with the windows executable downloaded from releases. However, when I built the executable myself, it worked great.

PS C:\Users\alpat\source\repos\ED-AFK-Notifier\cmd\ed-afk-notifier> go build
PS C:\Users\alpat\source\repos\ED-AFK-Notifier\cmd\ed-afk-notifier> .\ed-afk-notifier.exe
time="2022-06-09T22:45:06-05:00" level=info msg="Config:"
time="2022-06-09T22:45:06-05:00" level=info msg="  Notify fighter status: true"
time="2022-06-09T22:45:06-05:00" level=info msg="  Notify shields status: true"
time="2022-06-09T22:45:06-05:00" level=info msg="  Notify on kills: true (silent: false)"
time="2022-06-09T22:45:06-05:00" level=info msg="  Journal file path: C:\\Users\\alpat\\Saved Games\\Frontier Developments\\Elite Dangerous"
time="2022-06-09T22:45:07-05:00" level=info msg="Found most recent journal file: Journal.220609150554.01.log"
time="2022-06-09T22:45:07-05:00" level=info msg="Reading journal..."

image

@x2611
Copy link
Author

x2611 commented Jun 10, 2022

For what it's worth (I know nothing about go), I was having the same problem with the windows executable downloaded from releases. However, when I built the executable myself, it worked great.

Interesting. I believe you. I had the same thing happen with a Linux program years ago. Depo version would always crash to desktop immediately but the compiled source worked great. Computers are weird.

I might try this myself. Downloading Go now. Feeling hacky today lol.

@x2611
Copy link
Author

x2611 commented Jun 10, 2022

OK I compiled it and it's running. Need to grab some missions for testing. Comparing the compiled EXE to the two from releases, the sizes are all way different. What's up with that? And how do I know which one I built? The 32 or 64 bit? Thx.

Untitled

@x2611
Copy link
Author

x2611 commented Jun 10, 2022

Well nope. Compiled version don't work either :(
Could they have changed the log format? I recall
reading something about this a little while ago.

Untitled2
Screenshot_20220610-083947_Telegram

@tommyblue
Copy link
Owner

definitely I confirm the issue. I think it's caused by the most recent changes, I changed how the log files are parsed to be able to get the correct kills count even if the program is launched after the game has started. I'll take a look during the next days

@x2611
Copy link
Author

x2611 commented Jun 10, 2022

definitely I confirm the issue. I think it's caused by the most recent changes, I changed how the log files are parsed to be able to get the correct kills count even if the program is launched after the game has started.

Ok, good news. I hope you can fix it. But I thought we were supposed to start game first anyway so ED-AFK grabs the actual log file.

@tommyblue
Copy link
Owner

tommyblue commented Jun 10, 2022 via email

@x2611
Copy link
Author

x2611 commented Jun 10, 2022

Oh Ok, I understand. That sounds like a very nice feature. Anyways, I will be happy to help you test it going along. Let me know. X.

@tommyblue
Copy link
Owner

Oh Ok, I understand. That sounds like a very nice feature. Anyways, I will be happy to help you test it going along. Let me know. X.

will do, thanks

@x2611
Copy link
Author

x2611 commented Jul 11, 2022

Any luck mate?

@tommyblue
Copy link
Owner

Hi folks, sorry I didn't play ED in the last months. Today I played a bit and I tried to update some libs. I wasn't able to reproduce the issue, I always received the telegram messages (trying on linux). But the telegram lib had recent changes so I tried to update it.
I drafted a new release, it also contains other improvements I was trying to add. They're probably still a bit broken but some of them are cool (like auto-loading the new journal files when it changes, like when you exit the game then restart it). Let's give it a try and let me know if it fixes the issue 🙏🏼
https://github.com/tommyblue/ED-AFK-Notifier/releases/tag/v0.4.0-alpha

@x2611
Copy link
Author

x2611 commented Sep 20, 2022

Thanks Tommy, will try it out later.

@tommyblue
Copy link
Owner

ok thanks. I gave it a try on windows using the released binary and I received the messages correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants