Added support for per CPU core monitoring #301
Conversation
|
I will have to update the unit-tests to account for the change. |
|
Do you have a recommended way of updating the test-rrul.flent.gz file to include per-CPU core records? Should I recreate the flent file? Or do you recommend doing this in another way? |
test_plotters.py has a |
I've updated the pull request by adding the per-core CPU usage entries into the I think it would be better to recreate the test-rrul.flent.gz or change the |
|
Frey Alfredsson ***@***.***> writes:
I think it would be better to recreate the test-rrul.flent.gz or
change the PLOTS_MAY_FAIL to include which files these plots may fail
in. Then, if someone accidentally breaks it, they will fail in the
future.
Sounds good! Please do :)
|
Some of the test Flent files lack data for specific plots. This lack of data occurs either because the file did not include the parameter to create them or because the feature did not exist when it was created. The unit test framework ignores all plots that might lack data to ensure they will not fail when unintentional changes break these tests. However, this also means it will not catch changes that accidentally break them. This commit adds functionality to allow defining which plots should be omitted by the unit tests on a per-file basis, allowing testing of files that do include the plots. Signed-off-by: Frey Alfredsson <[email protected]>
|
I've updated this pull request to include a list of plots to ignore per unit-test file and added a test for the new per-core monitoring functionality. |
This commit adds multicore support to the stat_iterate.sh script and to the CpuStatsRunner. The previous script only read the first entry of the /proc/stat, which gave the average CPU usage for all cores. This modified script reads all cpu[0-9]+ records, including the average. It retains the output format of the original script; however, the implementation has some minor optimizations, which are not that significant due to how seldom the script runs. 1. It primarily relies on the awk command for the heavy lifting, making it easier to read. Awk handles reading the /proc/stat instead of the cat command. 2. The previous script used the seq command, which consumes more memory when multiple iterations occur. Awk handles this instead with a loop. I tested the script using gawk with and without the Posix compliance flag (-P), BusyBox v1.36.1 awk, and mawk 1.3.4. Signed-off-by: Frey Alfredsson <[email protected]>
|
I added that I tested the script with mawk 1.3.4 and added support for old versions of awk. However, I had no issues with the awk implementations I tested the script with. |
|
@freysteinn Wonderful thank you! |
This commit adds multicore support to the stat_iterate.sh script and to the CpuStatsRunner. The previous script only read the first entry of the /proc/stat, which gave the average CPU usage for all cores. This modified script reads all cpu[0-9]+ records, including the average. It retains the output format of the original script; however, the implementation has some minor optimizations, which are not that significant due to how seldom the script runs.
It primarily relies on the awk command for the heavy lifting, making it easier to read. Awk handles reading the /proc/stat instead of the cat command.
The previous script used the seq command, which consumes more memory when multiple iterations occur. Awk handles this instead with a loop.
I tested the script using gawk with and without the Posix compliance flag (-P) and BusyBox v1.36.1 awk.