Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fails after v0.18 proto update: missing RegisterPluginServer, RegisterNodeServer #727

Closed
gabriel-vasile opened this issue Feb 21, 2022 · 4 comments

Comments

@gabriel-vasile
Copy link
Contributor

$ go build *.go
# github.com/tinode/chat/server/plugins/users
plugins/users/plugin.go:22:2: undefined: pbx.RegisterPluginServer
@or-else
Copy link
Contributor

or-else commented Feb 21, 2022

I cannot reproduce.

% go build -ldflags "-s -w" -tags mysql -o ./releases/tmp/tinode ./server 
% 

@gabriel-vasile
Copy link
Contributor Author

Maybe instead of building the server, try building a plugin?

Maybe you noticed, maybe you didn't but the error complains about missing RegisterPluginServer.
Here is the commit where you removed it and here is a sample plugin to compile.

@or-else
Copy link
Contributor

or-else commented Feb 22, 2022

Maybe instead of building the server, try building a plugin?

Which plugin? Are you asking me to help you or telling me what to do?

Maybe you noticed

Maybe you should consider less confrontational approach to communication.

@gabriel-vasile
Copy link
Contributor Author

I don't get how this problem is so elusive to you. This function is what a program needs to call to register itself as a GRPC plugin and it was removed in v0.18.1.

Which plugin?

Any tinode GRPC plugin implementing this service.

Are you asking me to help you or telling me what to do?

I'm telling you what to do to reproduce the problem, because noticing the absence of the function is apparently impossible.

Maybe you should consider less confrontational approach to communication.

No, not for you.

@gabriel-vasile gabriel-vasile changed the title build fails after v0.18 proto update build fails after v0.18 proto update: missing RegisterPluginServer, RegisterNodeServer Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants