Bug-fix: text justification with rotation not implemented in geom_label()

[aphalo]

The code in geom_label() should pass to compute_just() the same arguments that geom_text() passes, including both x and y and angle in each of the two calls, one for hjust and one for vjust. This affects the handling of "inward" and "outward" justification that depending on the angle require different numerical values for justification.

Reprex run AFTER applying this bug fix.

(There is a separate problem in compute_just(), affecting both geometries as vjust for the 90 degrees rotated text seems to be "outward" instead of "inward", while hjust is correct. I will try fix this separate problem and make a separate pull request in a few days.)

library(ggplot2)

df <- data.frame(
  x = c(0, 0, 1, 1, 0.5),
  y = c(0, 1, 0, 1, 0.5),
  text = c("bottom-left", "top-left", "bottom-right", "top-right", "center-middle")
)

ggplot(df, aes(x, y, label = text)) +
  geom_text(hjust = "inward", vjust = "inward", angle = 90)

ggplot(df, aes(x, y, label = text)) +
  geom_text(hjust = "inward", vjust = "inward", angle = -90)

ggplot(df, aes(x, y, label = text)) +
  geom_label(hjust = "inward", vjust = "inward", angle = 90)

ggplot(df, aes(x, y, label = text)) +
  geom_label(hjust = "inward", vjust = "inward", angle = -90)

^{Created on 2023-09-15 with reprex v2.0.2}

[teunbrand]

To make it slightly more visual what the issue was:

devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2

df <- data.frame(
  x = c(0, 0, 1, 1, 0.5),
  y = c(0, 1, 0, 1, 0.5),
  text = c("bottom-left", "top-left", "bottom-right", "top-right", "center-middle")
)

ggplot(df, aes(x, y, label = text)) +
  geom_label(hjust = "inward", vjust = "inward", angle = 90, colour = "red") +
  geom_text(hjust = "inward", vjust = "inward", angle = 90)

ggplot(df, aes(x, y, label = text)) +
  geom_label(hjust = "inward", vjust = "inward", angle = -90, colour = "red") +
  geom_text(hjust = "inward", vjust = "inward", angle = -90)

^{Created on 2023-09-18 with reprex v2.0.2}

[teunbrand]

Thanks for putting together this PR! It looks good to me.
If you want, you can add either a separate news bullet, or add your username to the bullet below:

ggplot2/NEWS.md

Line 102 in 25f54d9

* `geom_label()` now uses the `angle` aesthetic (@teunbrand, #2785)

[aphalo]

Thanks! This is such a small PR that there is no need to add my name, I think. In an earlier PR I wrote myself the whole matching bugfix for geom_text().