Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test LoginService #12

Open
tiagodenoronha opened this issue Oct 21, 2018 · 1 comment
Open

Test LoginService #12

tiagodenoronha opened this issue Oct 21, 2018 · 1 comment
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@tiagodenoronha
Copy link
Owner

How should we test the login service?
We can create fake UserManager and fake SigninManager but does the trouble of mocking Signing and Token Configurations make it worth it?
@tiagodenoronha tiagodenoronha added help wanted Extra attention is needed question Further information is requested labels Oct 21, 2018
@tiagodenoronha
Copy link
Owner Author

The problem isn't with USerManager itself, but with SigninManager, since there is no easy way to mock it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tiagodenoronha