Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter on include: label causes lag and grinds the view #438

Open
Mariusthvdb opened this issue Apr 10, 2024 · 2 comments
Open

filter on include: label causes lag and grinds the view #438

Mariusthvdb opened this issue Apr 10, 2024 · 2 comments

Comments

@Mariusthvdb
Copy link

Mariusthvdb commented Apr 10, 2024

HA 2024.4.2
Auto-entities 1.13.0

Glad the new labels are implemented in the auto-entities config options (thanks!). However, something is causing a huge lag, so much so, it practically stops the view from responding.
Ive moved the testing configs for this from UI dashboards to yaml dashboards, as the editor simply wont open.

Als there seems to be a memory increase (see far right for the sudden spike on editing an auto-entities card with the option label filter)

Scherm­afbeelding 2024-04-09 om 10 35 45

though that is of lesser importance, and not 100% reproducible

The Frontend Lag is, I am afraid.

using a template filter is fine:

card:
  type: entities
filter:
  template: |
    {{label_entities('Theater')}}

but using the label include makes the card drag the view down:

type: custom:auto-entities
card:
  type: entities
  title: Auto label
filter:
  include:
    - label: theater

or

type: custom:auto-entities
card:
  type: entities
  title: test filter label auto entities
filter:
  include:
    - label: intercom_speler
  exclude:
    - state: unavailable

or a config like this, using the card_param:

            - type: custom:auto-entities
              card_param: cards
              filter:
                include:
                  - label: hub
                    options:
                      type: tile
              card:
                type: grid
                columns: 2
                square: false

they all show the correct entities, so the label include does work in itself.

That's why I opened this separate issue from another open issue

@Mariusthvdb
Copy link
Author

Mariusthvdb commented Apr 11, 2024

there's something I just noticed while adding a new auto-entities card via the UI flow (I didnt yet do that before, using all yaml, or just pasting yaml in the UI editor before):

seems like it pre-loads all entities in the editor, just like dev tools states does. Since I have a lot of entities, dev tools states has been the worst view by far in the system since forever.
Could it be auto-entities now is also bugged by this, now the label option has been added? Maybe not only in there UI editor, but now also in the final Dashboard itself?

@Mariusthvdb
Copy link
Author

Mariusthvdb commented Aug 15, 2024

Thomas, if you see this:

could you please check the PR in the mentioned HA issue above? That tries to add a throttler to the /config pages, because the frontend was unable to cope with the state changes constantly being evaluated and, well, changing....

It was only with that discussion, I realized it might be related to the issue here, being the exact same user experience.

Could it be that filtering the label in auto-entities is also seeing this same issue?
and a throttles a la that Pr would be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant