-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim-lsp-snippets breaks with ccls after vim-lsp merge #637 #6
Comments
@hrsh7th Can you help debug this issue? I'm wondering if this is the same problem as I had in thomasfaingnaert/vim-lsp-ultisnips#9. |
@d-karl To help with debugging, can you add some |
@d-karl Thanks for your report. Could you tell me whether you using ncm2-vim-lsp? I think the problem needs below steps to solve.
I will create PR for |
Thank you for invesitgating. I can confirm I am using ncm2-vim-lsp. Regarding uploading logs, I'll have to reproduce the issue on my personal machine first then get you logs from there. I can not give you logs from my work machine. |
Same problemI have the same problem with
Minimal vimrc[OK] check-hrsh7th.vimrcUse: call plug#begin('~/.vim/plugged-hrsh7th')
Plug 'prabirshrestha/async.vim'
Plug 'prabirshrestha/vim-lsp'
Plug 'hrsh7th/vim-lsp-snippets'
Plug 'hrsh7th/vim-lsp-ultisnips'
Plug 'SirVer/ultisnips'
Plug 'honza/vim-snippets'
call plug#end()
let g:lsp_log_file = expand('/tmp/vim-lsp-snippets-hrsh7th.log')
let g:lsp_diagnostics_enabled = 0
if executable('gopls')
augroup LspGo
au!
au User lsp_setup call lsp#register_server({
\ 'name': 'gopls',
\ 'cmd': {server_info->['gopls']},
\ 'whitelist': ['go'],
\ 'workspace_config': {
\ 'gopls': {
\ 'usePlaceholders': v:true,
\ }
\ }})
au FileType go setlocal omnifunc=lsp#complete
augroup end
endif
imap <c-j> <c-r>=UltiSnips#JumpForwards()<CR>
smap <c-j> <c-r>=UltiSnips#JumpForwards()<CR>
imap <c-k> <c-r>=UltiSnips#JumpBackwards()<CR>
smap <c-k> <c-r>=UltiSnips#JumpBackwards()<CR> [NG] check-thomasfaingnaert.vimrcUse: call plug#begin('~/.vim/plugged-thomasfaingnaert')
Plug 'prabirshrestha/async.vim'
Plug 'prabirshrestha/vim-lsp'
Plug 'thomasfaingnaert/vim-lsp-snippets'
Plug 'thomasfaingnaert/vim-lsp-ultisnips'
Plug 'SirVer/ultisnips'
Plug 'honza/vim-snippets'
call plug#end()
let g:lsp_log_file = expand('/tmp/vim-lsp-snippets-thomasfaingnaert.log')
let g:lsp_diagnostics_enabled = 0
if executable('gopls')
augroup LspGo
au!
au User lsp_setup call lsp#register_server({
\ 'name': 'gopls',
\ 'cmd': {server_info->['gopls']},
\ 'whitelist': ['go'],
\ 'workspace_config': {
\ 'gopls': {
\ 'usePlaceholders': v:true,
\ }
\ }})
au FileType go setlocal omnifunc=lsp#complete
augroup end
endif
imap <c-j> <c-r>=UltiSnips#JumpForwards()<CR>
smap <c-j> <c-r>=UltiSnips#JumpForwards()<CR>
imap <c-k> <c-r>=UltiSnips#JumpBackwards()<CR>
smap <c-k> <c-r>=UltiSnips#JumpBackwards()<CR> DemoLog (vim-lsp-snippets-thomasfaingnaert.log)Error topic
|
After seeing the errror @yaegassy gets in the log, I realized my log also contains an error message, althought it is a different one:
Again, sorry for not providing the whole log yet. |
@yaegassy I've merged the PRs. Can you confirm your issue has been fixed? |
@d-karl The way vim-lsp handles user_data was recently changed. Can you update your plugins and check if the issue has been solved with the latest vim-lsp-ultisnips and vim-lsp-snippets? |
This problem has been resolved. |
I sent PR to vim-lsp. After merged the PR, I will sent PR to ncm2-vim-lsp. |
Can also confirm the newest versions of: |
Hm... IMO, snippet feature does not work on currently ncm2-vim-lsp... (because it overwrites user_data). Although, your environment works fine is good. |
Great. Thanks to everyone involved in getting to the bottom of this. |
Hi, I have a problem using:
ncm2
vim-lsp
vim-lsp-snippets
vim-lsp-ultisnips
working with the ccls server to edit c++.
After the merge of prabirshrestha/vim-lsp#637 (commit prabirshrestha/vim-lsp@f769a45) into vim-lsp, vim-lsp no longer provies any auto completions using the above combination while editing c++ using ccls. Using vim-lsp with pyls still works correctly and supplies auto completion items, which can be expanded into snippets. I have determined the problematic commit using bisect, the previous commit on master works.
I have checked vim-lsp log, and completion items are retrived just fine. Something else later down the chain breaks. Disabling vim-lsp-snippets gives me back completion items, but obviously does not allow me to expand completion items as snippets. I hope I am in the right place to report this and would love to help any way I can!
The text was updated successfully, but these errors were encountered: