Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] sof-test should run without DMA trace - only etrace #726

Open
plbossart opened this issue Jul 1, 2021 · 12 comments
Open

[FEATURE] sof-test should run without DMA trace - only etrace #726

plbossart opened this issue Jul 1, 2021 · 12 comments
Labels
area:logs Log and results collection, storage, etc. P2 Critical bugs or normal features type:enhancement New framework feature or request

Comments

@plbossart
Copy link
Member

Is your feature request related to a problem? Please describe.

Facts:

We should be able to run sof-tests, possibly in a more limited version since less information is available, without requiring the DMA trace to be enabled.

Describe the solution you'd like
autodetection that only /sys/kernel/debug/sof/etrace is available and skips of all DMA trace parsing/error detection

Describe alternatives you've considered
none

@lgirdwood @kv2019i @marc-hb @aiChaoSONG @fredoh9 @ranj063 @lyakh FYI

@plbossart plbossart added the type:enhancement New framework feature or request label Jul 1, 2021
@marc-hb
Copy link
Collaborator

marc-hb commented Jul 1, 2021

We already have a -s option: #681

What's missing and and what level? In run-all-tests.sh marc-hb@run-all-nologger ?

@plbossart
Copy link
Member Author

plbossart commented Jul 7, 2021

@marc-hb I don't want to disable sof-logger (which will read the etrace which is ALWAYS enabled).

I just want to disable the DMA trace.... (sof-logger -t) which is conditionally enabled by the kernel.

@plbossart
Copy link
Member Author

See e.g. thesofproject/sof#3673, how would one run such tests if we cannot disable the DMA trace...

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 7, 2021

I just tried modprobe snd_sof sof_debug=0 as documented at https://thesofproject.github.io/latest/developer_guides/debugability/logger/index.html but the firmware seems to still receive the same ipc: debug cmd 0x30000 request from the kernel to enable the DMA trace.

@plbossart
Copy link
Member Author

@marc-hb try PR thesofproject/linux#3021, that disables the trace for real. The current code can only enable the trace with the module parameter, not disable it.

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 8, 2021

@marc-hb try PR thesofproject/linux#3021, that disables the trace for real.

Does not apply to CI but in my workspace I found it easier to turn off CONFIG_SND_SOC_SOF_DEBUG_ENABLE_FIRMWARE_TRACE. Then I upgraded sof_insert.sh to support modules parameters (#734) and with that a simple ./test-case/check-playback.sh -s runs fine and passes. As I wrote earlier, the etrace still works.

@marc-hb
Copy link
Collaborator

marc-hb commented Nov 24, 2021

#811 to disable the logger entirely (even etrace)

@marc-hb marc-hb added the area:logs Log and results collection, storage, etc. label Jan 21, 2022
@plbossart
Copy link
Member Author

#811 to disable the logger entirely (even etrace)

that's not what I was asking - only disable DMA traces and keep etrace

@marc-hb
Copy link
Collaborator

marc-hb commented Jan 28, 2022

I know, that's why this is not closed.

@plbossart
Copy link
Member Author

this is still open IMHO

@marc-hb marc-hb added the P1 Blocker bugs or important features label Sep 22, 2022
@aiChaoSONG aiChaoSONG added P2 Critical bugs or normal features and removed P1 Blocker bugs or important features labels Jan 9, 2023
@aiChaoSONG
Copy link

We focus on IPC4 dev now, this is IPC3 specific, make it P2

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 15, 2024

Resurrecting #1065 would probably be a good start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Log and results collection, storage, etc. P2 Critical bugs or normal features type:enhancement New framework feature or request
Projects
None yet
Development

No branches or pull requests

3 participants