Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] use --fatal-errors for aplay/arecord tests #1120

Open
plbossart opened this issue Oct 27, 2023 · 4 comments
Open

[FEATURE] use --fatal-errors for aplay/arecord tests #1120

plbossart opened this issue Oct 27, 2023 · 4 comments
Labels
False Pass / green failure type:bug Something doesn't work as expected

Comments

@plbossart
Copy link
Member

Is your feature request related to a problem? Please describe.
When we reach an xrun, we should stop sof-test scripts. xruns need to be recoverable, but they should never happen. we don't want to miss these issues because the recovery quicks-in and hides problems.

Describe the solution you'd like
Add --fatal-errors to aplay/arecord command-line options.

Example run with --test-position (needs aplay patch to dump the last result)

Status(R/W) (standalone avail=36 delay=924):
  state       : RUNNING
  trigger_time: 2045.504937
  tstamp      : 2190.754602
  delay       : 924
  avail       : 36
  avail_max   : 444
Status(R/W) (standalone avail=44 delay=912):
  state       : RUNNING
  trigger_time: 2045.504937
  tstamp      : 2190.754852
  delay       : 912
  avail       : 48
  avail_max   : 48
underrun!!! (at least 471.161 ms long)
Status:
  state       : XRUN
  trigger_time: 2190.786234
  tstamp      : 2191.257392
  delay       : 0
  avail       : 1412
  avail_max   : 1412
aplay: xrun:1690: fatal underrun: Success

Describe alternatives you've considered
none that I can think of

Additional context
Not sure if we want to add this in sof-test proper, or add this in the environment variables with "APLAY_OPTS" that are already supported.

@plbossart
Copy link
Member Author

related PR: alsa-project/alsa-utils#242

@marc-hb marc-hb added type:bug Something doesn't work as expected False Pass / green failure labels Aug 13, 2024
@plbossart
Copy link
Member Author

btw this PR alsa-project/alsa-utils#242 was merged so most likely we can "just" add this --fatal-errors option to tests?

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 15, 2024

Yes, work in "progress": b4523e0

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 15, 2024

btw this PR alsa-project/alsa-utils#242 was merged

We don't have a way to upgrade ALSA on test devices AFAIK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Pass / green failure type:bug Something doesn't work as expected
Projects
None yet
Development

No branches or pull requests

2 participants