Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: options should be set on the internal options object #8

Open
jonathanong opened this issue May 10, 2015 · 4 comments
Open

Comments

@jonathanong
Copy link
Contributor

so that they persist across requests

@felixfbecker
Copy link

What do you mean by that? Instead of returning a new request client when request.defaults() is called?

@jonathanong
Copy link
Contributor Author

@felixfbecker i don't remember... probably

@felixfbecker
Copy link

xD

@jonathanong
Copy link
Contributor Author

ok i think this is for two reasons:

  • easy to set defaults to extend from it
  • easy to retry a request (needed for retry support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants