Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TLS support for Redis #718

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

diegopatinor
Copy link

@@ -20,6 +20,7 @@ const env = cleanEnv(process.env, {
REDIS_PORT: num({ default: 6379 }),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If TLS is enabled, should we change the default port to 6380 if there isn't one set explicitly?
Like:
TLS disabled => REDIS_PORT=env.REDIS_PORT or 6379
TLS enabled => REDIS_PORT=env.REDIS_PORT or 6380

@@ -20,6 +20,7 @@ const env = cleanEnv(process.env, {
REDIS_PORT: num({ default: 6379 }),
REDIS_PASSWORD: str({ default: "" }),
REDIS_DB: num({ default: 0 }),
REDIS_SSL: bool({ default: false }),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a "deprecated" term like SSL instead of TLS directly?
PS: Some projects use REDIS_PROTOCOL (here you are proposing REDIS_SSL) as a flag with 2 options: (redis, rediss) as in (redis://:<password>@<host>:<port>/<db>, rediss://:<password>@<host>:<port>/<db>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants