Skip to content
This repository has been archived by the owner on Oct 14, 2019. It is now read-only.

Fix TODOs in the code. #275

Open
thecsw opened this issue Nov 25, 2018 · 2 comments
Open

Fix TODOs in the code. #275

thecsw opened this issue Nov 25, 2018 · 2 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@thecsw
Copy link
Owner

thecsw commented Nov 25, 2018

I will merge my branch soon, it is a huge branch that cleans up the code and makes it a bit faster. PEP8 compliance mostly. I left quite a bit number of TODOs, if you wish to support this project and familiarize yourself with our codebase, feel free to hunt them down and execute them mercilessly.

Some of them include:

  • Adding docstrings
  • Getting rid of broad try-except blocks
  • Reducing the size of some functions (fewer branches and statements)
@thecsw thecsw added the good first issue Good for newcomers label Nov 25, 2018
@thecsw thecsw added this to the Season 2 milestone Nov 25, 2018
@Keanu73
Copy link
Contributor

Keanu73 commented May 16, 2019

@thecsw You reckon this is still valid or not really needed since the rewrite in Go?

@Keanu73
Copy link
Contributor

Keanu73 commented Jun 12, 2019

I think this issue can be closed since we'll adopt all of these practices in the Go rewrite (and we already have)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants