This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
fix: body callbacks return the whole buffered body size #418
+17
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetake
reviewed
Dec 23, 2023
mathetake
reviewed
Dec 23, 2023
mathetake
reviewed
Dec 23, 2023
|
As I commented, please make sure that each PR has a narrow scope rather than having multiple ones so that we can investigate the history easily later |
M4tteoP
force-pushed
the
clarify_body_buffer
branch
from
d9e391b
to
0306f95
Compare
|
Thanks, done (and sorry for the hiccup)! This PR has been restricted to the main topic: emulator and related existing Other PRs created are:
|
mathetake
approved these changes
Dec 23, 2023
| } | ||
|
|
||
| // Override types.DefaultHttpContext. | ||
| func (ctx *setBodyContext) OnHttpRequestHeaders(numHeaders int, endOfStream bool) types.Action { | ||
| mode, err := proxywasm.GetHttpRequestHeader("buffer-replace-at") | ||
| if mode == "response" { | ||
| if err == nil && mode == "response" { |
There was a problem hiding this comment.
curious what's the reason for this check?
There was a problem hiding this comment.
err is retrieved but not used. I was in doubt about whether not even retrieve it, or to ensure it was nil before relying on mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #414 discussion this PR tries to:
ProxyOnRequestBodyandProxyOnResponseBodythe size of the whole body buffer, not of the individual chunk.http_bodyexample.Adds→ See example: adds http_body_chunk #421http_body_chunkexample showing how to read chunk by chunk while buffering.nit: fix: typo #410→ See chore: fixes typos #419upgrades support for latest envoy and istio/proxyv2→ See chore: upgrades support for latest envoy and istio/proxyv2 #420Tentatively closes #414.