Skip to content
This repository has been archived by the owner on Jul 15, 2018. It is now read-only.

encode complex types as "%+v" #77

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Nov 6, 2017

Refs #18

@melekes
Copy link
Contributor Author

melekes commented Nov 6, 2017

BEFORE:
BenchmarkTMLoggerSimple-2                 200000              5830 ns/op             752 B/op       17 allocs/op
BenchmarkTMLoggerContextual-2             200000              6399 ns/op            1104 B/op       23 allocs/op
BenchmarkTMFmtLoggerSimple-2              300000              4953 ns/op             273 B/op        9 allocs/op
BenchmarkTMFmtLoggerContextual-2          300000              5384 ns/op             481 B/op       13 allocs/op

AFTER:
BenchmarkTMLoggerSimple-2                 200000              5845 ns/op             752 B/op       17 allocs/op
BenchmarkTMLoggerContextual-2             200000              6346 ns/op            1104 B/op       23 allocs/op
BenchmarkTMFmtLoggerSimple-2              300000              4990 ns/op             273 B/op        9 allocs/op
BenchmarkTMFmtLoggerContextual-2          200000              5577 ns/op             481 B/op       13 allocs/op

@codecov-io
Copy link

codecov-io commented Nov 6, 2017

Codecov Report

Merging #77 into develop will decrease coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #77      +/-   ##
===========================================
- Coverage    57.17%   57.13%   -0.04%     
===========================================
  Files           49       49              
  Lines         4318     4321       +3     
===========================================
  Hits          2469     2469              
- Misses        1669     1671       +2     
- Partials       180      181       +1
Impacted Files Coverage Δ
log/tmfmt_logger.go 80% <75%> (-3.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0cf0b...6944756. Read the comment docs.

Copy link
Contributor

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@melekes melekes merged commit 176c2ce into develop Nov 8, 2017
@melekes melekes deleted the 18-unsupported-value-type branch November 8, 2017 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants