Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShadowRealms WPT Problems #397

Open
mgaudet opened this issue Feb 1, 2024 · 4 comments
Open

ShadowRealms WPT Problems #397

mgaudet opened this issue Feb 1, 2024 · 4 comments
Assignees

Comments

@mgaudet
Copy link

mgaudet commented Feb 1, 2024

Here are some issues I've seen in the ShadowRealms WPT that -might- be implementation specific, but I'd be curious about feedback from other implementations running tests:

@caridy
Copy link
Collaborator

caridy commented Feb 5, 2024

/cc @rwaldron

@rwaldron
Copy link
Collaborator

rwaldron commented Feb 8, 2024

The failures around undefined references are caused by those external script resources not being loaded into the ShadowRealm created for the test. That's not an "issue" with ShadowRealms or testing of ShadowRealms, it's just a bug in the test harness that needs to be fixed.

@rwaldron
Copy link
Collaborator

rwaldron commented Feb 8, 2024

The reason assert_Memory is undefined is because it needs to be set as globalThis.assert_Memory = ... in wasm/jsapi/memory/assertions.js

@rwaldron
Copy link
Collaborator

rwaldron commented Feb 8, 2024

As for the encoding back pressure issues, I can't say why that doesn't work—it looks like the outcomes are out of order? There's nothing about ShadowRealm itself that would cause that. I wanted to try running that test in either of the other implementations, but couldn't get my local runner to pick up the /encoding/streams/backpressure.any.shadowrealm.html test, even though it is definitely in the manifest 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants