From e81c0023967d077708931c3b927488279ce01b76 Mon Sep 17 00:00:00 2001 From: Joshua Aresty Date: Fri, 9 Aug 2024 18:21:14 -0700 Subject: [PATCH 1/2] Anchor the VSCode please command - I was frequently getting this triggered in the middle of other commands - I don't think it makes sense to chain this command --- apps/vscode/vscode.talon | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/vscode/vscode.talon b/apps/vscode/vscode.talon index 275398d0e4..032fbbc3df 100644 --- a/apps/vscode/vscode.talon +++ b/apps/vscode/vscode.talon @@ -10,7 +10,7 @@ window reload: user.vscode("workbench.action.reloadWindow") window close: user.vscode("workbench.action.closeWindow") #multiple_cursor.py support end -please []: +^please []$: user.vscode("workbench.action.showCommands") insert(user.text or "") From b6427c96299b0c4f2cc27ba2e65b0bac399b7fc0 Mon Sep 17 00:00:00 2001 From: Joshua Aresty Date: Sat, 10 Aug 2024 20:12:57 -0700 Subject: [PATCH 2/2] I'm opting to simply anchor the current please commands - since jetbrains is already different, I'm not sure which way to go if I were to try and consolidate with the single overrideable helper. - if it is preferable to come up with a single overrideable helper, I'm happy to do so but would like some guidance what to do with jetbrains --- apps/arc/arc_mac.talon | 2 +- apps/eclipse/eclipse.talon | 2 +- apps/jetbrains/jetbrains.talon | 2 +- apps/vivaldi/vivaldi.talon | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/arc/arc_mac.talon b/apps/arc/arc_mac.talon index ce881590e4..b1099d2439 100644 --- a/apps/arc/arc_mac.talon +++ b/apps/arc/arc_mac.talon @@ -4,7 +4,7 @@ os: mac tag(): browser tag(): user.tabs -please []: +^please []$: key("cmd-l") sleep(200ms) insert(user.text or "") diff --git a/apps/eclipse/eclipse.talon b/apps/eclipse/eclipse.talon index 15c06d55b8..395073c9c5 100644 --- a/apps/eclipse/eclipse.talon +++ b/apps/eclipse/eclipse.talon @@ -8,7 +8,7 @@ tag(): user.splits tag(): user.tabs # splits.py support end -please []: +^please []$: key(ctrl-3) insert(user.text or "") diff --git a/apps/jetbrains/jetbrains.talon b/apps/jetbrains/jetbrains.talon index ea5735dc4e..b5bb757d98 100644 --- a/apps/jetbrains/jetbrains.talon +++ b/apps/jetbrains/jetbrains.talon @@ -16,7 +16,7 @@ smart: user.idea("action SmartTypeCompletion") grab : user.idea_grab(number) # Actions (action | please): user.idea("action GotoAction") -(action | please) : +^(action | please) $: user.idea("action GotoAction") insert(text) # Refactoring diff --git a/apps/vivaldi/vivaldi.talon b/apps/vivaldi/vivaldi.talon index 978e71e74c..5e5706c63a 100644 --- a/apps/vivaldi/vivaldi.talon +++ b/apps/vivaldi/vivaldi.talon @@ -8,7 +8,7 @@ tag(): user.tabs (sidebar | panel) bookmarks: user.vivaldi_bookmarks_panel() (sidebar | panel) notes: user.vivaldi_notes_panel() -please []: +^please []$: user.vivaldi_toggle_quick_commands() sleep(180ms) insert(user.text or "")