Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal modifier for POGivenTH #2

Open
talbrecht opened this issue Oct 6, 2016 · 5 comments
Open

Add internal modifier for POGivenTH #2

talbrecht opened this issue Oct 6, 2016 · 5 comments

Comments

@talbrecht
Copy link
Owner

Regarding the commits in https://github.com/talbrecht/pism_pik06/commits/ocean_th_06 there are two aspects that should be discussed for the ocean_th model:

  1. Introduce a lower limit of the base for grounded cells to avoid excessive melt
  2. Introduce a delta_T modifier, that should not go below pressure melting point
@talbrecht
Copy link
Owner Author

Using the default delta_T modifier causes unreasobale scaling of shelbmassflux!

@matthiasmengel
Copy link
Collaborator

Can you elaborate a bit on this? I think we talked about this shortly on skype. so the delta_T does not affect the input fields, but the boundary layer temperature directly, therefore bypassing our 3eqn melting ansatz? we should ask constantine on this when we are sure.

@talbrecht
Copy link
Owner Author

right, it is the order of calculations that matters: the ocean coupler calculates shelbtemp and shelbmassflux and the -delta_T modifier can add an anomaly to the calculated schelfbtemp. This is problematic since the modifier should be added to the input fields or to the shelfbtemp before the calculation of shelfbmassflux (second option has been realized in pism-pik06). And, shelfbtemp should be bounded below by the pressure melting point...

@matthiasmengel
Copy link
Collaborator

I think this a general design question then. Valid for other ocean models to come. We should post this on the main issue tracker, shouldn't we?

@talbrecht
Copy link
Owner Author

you mean in pism dev as a wish? Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants