Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Use of Angular Material Side Navbar module will reduce code #101

Open
3 tasks
lunayach opened this issue Mar 11, 2018 · 5 comments
Open
3 tasks

Use of Angular Material Side Navbar module will reduce code #101

lunayach opened this issue Mar 11, 2018 · 5 comments

Comments

@lunayach
Copy link
Member

lunayach commented Mar 11, 2018

Description

As a coder,
I need to use the existing APIs,
so that the code becomes cleaner and efficient.
We are writing the toggle() method to hide and show and writing explicitly the animations for changing the state.

Mocks

N.A.

Acceptance Criteria

Update

  • Use of Angular Material Side Navbar module. i.e. {MatSidenavModule} in Navabar component.

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1-2 Hrs.

@shreyans29
Copy link

Hey @lunayach , You can work on this Issue, but I see the estimation is way below the actual time it might take. Once you change the orientation of other components may change and you will have to fix them also. Any way go ahead with this. Send a PR when done.

@shreyans29
Copy link

Also Please update the issue, and put the statement you have put in mocks below description. Mocks are supposed to be graphical representations of what the end result might look like.

@lunayach
Copy link
Member Author

@shreyans29 Yes I also realize the same 👍

@lunayach
Copy link
Member Author

@shreyans29 as my previous PR is not merged, shall I have to make a new branch and commit changes for both the PR's(i.e. this one and the earlier unmerged PR) and then do the PR.

@shreyans29
Copy link

@lunayach No, your new PR should only contain the changes for this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants