Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audout:a audout:d aud:a aud:d #636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ITotalJustice
Copy link
Contributor

Application use: I use this in sys-tune to allow for per title volume control whilst keeping the master volume the same.

I've tried to match the style of audout.c/h. It is lacking comments, but i think the function names are descriptive enough.

I have a wrapper for common functions as well, but that probably doesn't belong in libnx :)

u64 delay;
} in = { pid, delay };

return serviceDispatchInOut(&g_audoutaSrv, 0, in, *handle_out);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct for output-handle, see elsewhere.

@@ -83,3 +103,15 @@ u32 audoutGetSampleRate(void); ///< Supported sample rate (
u32 audoutGetChannelCount(void); ///< Supported channel count (2 channels).
PcmFormat audoutGetPcmFormat(void); ///< Supported PCM format (Int16).
AudioOutState audoutGetDeviceState(void); ///< Initial device state (stopped).

Result audoutaRequestSuspendOld(u64 pid, u64 delay, Handle* handle_out); // [1.0.0] - [4.0.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- [3.0.2]

@fincs
Copy link
Contributor

fincs commented Feb 3, 2024

Any updates on the above review comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants