Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distributed] remote calls over-retain returned values #76595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Sep 20, 2024

We missed to deinitialize a return value buffer and only destroyed it, leading to over-retained objects returned from remote calls.

rdar://136313477
rdar://136338200

@ktoso ktoso added distributed Feature → concurrency: distributed actor memory leak bug: Memory leak labels Sep 20, 2024
@ktoso ktoso changed the title Debugging why we're not releasing executed distributed target return values [Distributed] remote calls over-retain returned values Sep 20, 2024
@ktoso ktoso force-pushed the wip-release-dist-execute-return branch from 5be1751 to cd3c60b Compare September 20, 2024 05:31
@ktoso
Copy link
Contributor Author

ktoso commented Sep 20, 2024

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-release-dist-execute-return branch from cd3c60b to 64f2287 Compare September 20, 2024 05:33
resolves rdar://136338200
resolves rdar://136313477
@ktoso ktoso force-pushed the wip-release-dist-execute-return branch from 64f2287 to a12420a Compare September 20, 2024 05:33
@ktoso
Copy link
Contributor Author

ktoso commented Sep 20, 2024

@swift-ci please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor memory leak bug: Memory leak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant