Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Path to Monorepo (Turborepo) #32

Closed
2 tasks
vnphanquang opened this issue Feb 24, 2023 · 2 comments · Fixed by #79
Closed
2 tasks

Migration Path to Monorepo (Turborepo) #32

vnphanquang opened this issue Feb 24, 2023 · 2 comments · Fixed by #79
Assignees
Milestone

Comments

@vnphanquang
Copy link
Member

vnphanquang commented Feb 24, 2023

Initial Context

As the title states, should we consider turning this project into a monorepo (even though there's just one site) to be able to use remote caching?

No reason not to 🤔 ?

Update

Following #60, remote caching doesn't make sense anymore. Instead, monorepo migration acts as preparation for scaling up the repo. For example, #72 and #38 will require additional code to be added; we should scope these as separate projects within a monorepo, for better scoping (better than multiple repos), dependency sharing, and later on version tracking #76.

Todo

  • migrate to turborepo
  • re-configure cloudflare build settings
@vnphanquang vnphanquang self-assigned this Feb 24, 2023
@vnphanquang vnphanquang added this to the Lạc Việt milestone Feb 24, 2023
@lvnam96
Copy link

lvnam96 commented Apr 21, 2023

How about "secret" env variables (if existed)? As they are supposed to be different among environments, does remote caching bring any benefits?

@vnphanquang vnphanquang modified the milestones: Lạc Việt, Anytime Apr 22, 2023
@vnphanquang
Copy link
Member Author

@lvnam96 yes, supposedly. Env can be added to cache config, basically if 2 build with same env but different values will result in 2 hashed builds.

The best benefit of concern here is remote caching, which would bring a shared cache to multiple devs working on the same project, and also the same cache for pipeline, potentially saving resources across the project.

However, considering the current scope & scale of this project (just me working in my own time, no stable production env yet), caching won't have much impact. Also, in #60, deployment was migrated to cloudflare from vercel, and enabling remote caching in cloudflare pipeline is not what I have experience in. Therefore this issue is still in backlog and kept for later consideration.

@vnphanquang vnphanquang changed the title Migrate to Turborepo to leverage Remote Caching? Migration Path to Monorepo Jun 6, 2023
@vnphanquang vnphanquang changed the title Migration Path to Monorepo Migration Path to Monorepo (Turborepo) Jun 6, 2023
@vnphanquang vnphanquang linked a pull request Jun 6, 2023 that will close this issue
2 tasks
@vnphanquang vnphanquang mentioned this issue Jun 6, 2023
2 tasks
@vnphanquang vnphanquang modified the milestones: Anytime, Discord 101 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants