Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only warn on context="module" in runes mode #13332

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Rich-Harris
Copy link
Member

we decided to only deprecate <script context="module"> in runes mode, as it causes noisy warnings for certain libraries

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 7bd9320

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti merged commit 2553932 into main Sep 19, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the module-context-warning branch September 20, 2024 00:05
@SaintPepsi
Copy link

Does that mean we shouldn't be using `<script context="module"> anymore for storing svelte component related data that might be imported by other components?

Is there a discussion on this I can read?
Will you just need to create a seperate JS/TS file instead?

@Rich-Harris
Copy link
Member Author

It is now just <script module>

@SaintPepsi
Copy link

SaintPepsi commented Sep 21, 2024

I just tried this, however I get a warning if I do this:

<script module lang="ts">
	export const foo = 'foo';
</script>
<script lang="ts">
	let bar = $state('bar');
	const { gravy } = $props();
</script>
A component can have a single top-level `<script>` element and/or a single top-level `<script context="module">` elementsvelte(script_duplicate)

I get a warning if I do this:

<script module lang="ts">
	export const foo = 'foo';
	let bar = $state('bar');
	const { gravy } = $props();
</script>
`$props()` can only be used at the top level of components as a variable declaration initializersvelte(props_invalid_placement)

@dummdidumm
Copy link
Member

Make sure you're on the latest version

@SaintPepsi
Copy link

SaintPepsi commented Sep 21, 2024

@dummdidumm I'm on ^5.0.0-next.257
Not sure what changed but this morning the warning for the single top-level script is gone. perhaps something to do with the language server?

Anyway thanks for the comments all resolved 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants