Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCone #12

Open
egpbos opened this issue Jul 25, 2019 · 1 comment
Open

Add OpenCone #12

egpbos opened this issue Jul 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@egpbos
Copy link
Collaborator

egpbos commented Jul 25, 2019

We could add an object tentatively called an open cone, which would be a cone with no height, i.e. one that extends infinitely into one direction. Such an object has one parameter less than the Cone. The radius and the height (both meaningless for this infinite object) are replaced by the single opening angle parameter. The fact that there is one less parameter, may make fitting easier. In the case of sundials, this is then the preferred option, since it does not actually make sense to limit the cone in height and radius, as we must do now.

@egpbos egpbos added the enhancement New feature or request label Jul 25, 2019
@egpbos
Copy link
Collaborator Author

egpbos commented Jul 25, 2019

Note that we will still need the z >= 0 constraint to properly constrain the implicit cone equation to only consider one cone. One could in theory also add a DoubleOpenCone that would only need the implicit equation, no constraints. The applicability of that may be less, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant