Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage: Rescan doesn't add duplicate request id to Record #1

Open
tynes opened this issue Apr 6, 2020 · 0 comments
Open

Test coverage: Rescan doesn't add duplicate request id to Record #1

tynes opened this issue Apr 6, 2020 · 0 comments

Comments

@tynes
Copy link
Contributor

tynes commented Apr 6, 2020

I think the current implementation of the Records will allow for duplicate request ids being added to the requests array.

Possible fixes:

  • Make requests into a Set instead of an array
  • Add hasRequestId method to the records and check that function before inserting a request id into the requests property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tynes