Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace half diacritics U+FE20, U+FE21 with correct diacritic U+0361 #1375

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Mar 1, 2024

In my research I tried Unicode normalization with this set of characters. It did not work. From what I can gather U+FE20 and U+FE21 are specific marks that don't have any correlation with U+0361.

Closes sul-dlss/SearchWorks#4010

@dnoneill dnoneill changed the title replace half diacritics U+FE20, U+FE21 with full diacritic U+0361 replace half diacritics U+FE20, U+FE21 with correct diacritic U+0361 Mar 1, 2024
Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test please?

@dnoneill dnoneill force-pushed the 4010-diacritics branch 2 times, most recently from bd29dcb to 930900e Compare March 1, 2024 21:36
@jcoyne jcoyne merged commit 9e9e7ff into main Mar 1, 2024
2 checks passed
@jcoyne jcoyne deleted the 4010-diacritics branch March 1, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder: Cyrillic diacritics follow-up
2 participants