Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Validate typings using actual tsc compiler #70

Open
robertrossmann opened this issue Jan 28, 2019 · 3 comments
Open

Validate typings using actual tsc compiler #70

robertrossmann opened this issue Jan 28, 2019 · 3 comments

Comments

@robertrossmann
Copy link
Member

The typings behave somewhat different when working on them inside this project and when they are being consumed as a module installed from npm (see #69).

We should add some kind of minimum TypeScript project which will try to consume the packages as if they were installed from npm and attempt to compile the TypeScript project to make sure the type definition files are actually working from a user perspective, not just from Atlas-maintainer perspective. 💪

@yunicz
Copy link

yunicz commented Apr 29, 2019

Yeah, this basically prevents us from using any typing when working with atlas, luckily you can simply overcome this issue and get your project compiled by requiring atlas instead of importing it
const { Atlas } = require('@atlas.js/atlas');

@robertrossmann
Copy link
Member Author

@yunicz what is the problem when trying to import @atlas.js/atlas? I tried on at least two projects and the typings are available when I use import statements:

import { Atlas } from '@atlas.js/atlas'

If you could share any TypeScript compilation errors that would be very helpful. 🙏

@yunicz
Copy link

yunicz commented May 30, 2019

nvm I am stupid, maybe just make componentOptions optional so that we don't have to write { aliases: {} } everytime component has no deps

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants