Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from zip to installer #32

Closed
joshuacant opened this issue Jan 20, 2020 · 2 comments · Fixed by #52 · May be fixed by #38
Closed

Switch from zip to installer #32

joshuacant opened this issue Jan 20, 2020 · 2 comments · Fixed by #52 · May be fixed by #38

Comments

@joshuacant
Copy link

Hi, would it be possible to switch this package from using the zip file (extracted to choco's lib folder) to the actual installer? I notice the streamlink package is using the installer method, but this one is not.

Thanks for considering this change, and I appreciate all the work you've done.
@scowalt
Copy link
Member

scowalt commented Jan 20, 2020

In situations like this, software will tend to have 3 chocolatey packages: an "install" package while uses the installer, a "portable" package which uses the zip file, and a "main" package which installs the "install" package. See 7zip as an example

image

Ideally, we would follow this same structure, since streamlink-twitch-gui has portable and install versions.

(I won't be able to look at this anytime soon, just wanted to give some background)

Thanks for the feedback!

@bastimeyer
Copy link
Member

As an addition from my side, I personally haven't tested a silent install yet, but after checking the installer.nsi and NSIS documentation again, I think it *should* be fine.

Parameters are documented here:
https://nsis.sourceforge.io/Docs/Chapter3.html#installerusage

@Conjuro Conjuro mentioned this issue Jun 6, 2020
Draft
13 tasks
@scowalt scowalt mentioned this issue Aug 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bastimeyer @scowalt @joshuacant