-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: description on readonly boards #1674
base: master
Are you sure you want to change the base?
fix: description on readonly boards #1674
Conversation
without this, you cannot select text, not interact with link etc.
binding.descriptionEditor.setEnabled(false); | ||
binding.descriptionEditorWrapper.setVisibility(GONE); | ||
binding.descriptionViewer.setEnabled(false); | ||
binding.descriptionViewer.setEnabled(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not necessary to view the description, but it seems mandatory to interact with it (links, selection...)
@@ -123,7 +123,7 @@ | |||
android:textIsSelectable="true" | |||
android:textSize="@dimen/font_size_description" | |||
android:translationY="1dp" | |||
android:visibility="gone" /> | |||
android:visibility="visible" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing works without this
Thank you for the contribution! I'm currently on vacation and will try to review the changes after Sept 25th. |
After many attempts, I was finally able to make it! Tested with a prod server, with and without readonly boards, everything works as expected :)
But I must admit I am not fully confident with the code, I never tried to play with java code before, so I don't even understand completely why those peace of code were missing...
I'd love to have your feedbacks @stefan-niedermann