Jenkins Builds

@status-im/mobile-qa : This PR enables new architecture in react-native for android builds. It was already enabled for iOS right after montenegro offsite. We don't expect it to cause any platform specific issues on Android but never the less a smoke test should be good enough ( only when you have the time, I know you're busy with release testing ).

@mariia-skrypnyk : nothing new on this one, I'll ping you when I have more news on this one.
Thanks for checking in.

In debug mode I did notice a bunch of abort signals originating from reanimated library :

node_modules/react-native-reanimated/Common/cpp/NativeModules/NativeReanimatedModule.cpp:603: 
function operator(): assertion failed (family.getSurfaceId() == surfaceId_)

I'll try to see if they're fixed in a newer version of reanimated or try to temporarily patch them out.

Finally I'm able to reproduce this issue in debug variant.

This gives us good hints that the bug indeed originates due to hole view library and at his component
quo.components.profile.profile_card.view.profile_card

cc @status-im/mobile : can you please find some alternative approach or a temp fix for this issue?
A good solution would indeed involve getting rid of react-native-hole-view library, however that should be another PR :)

 ERROR  Error: Exception in HostFunction: Loss of precision during arithmetic conversion: 
 (long) 371.42857142857144

This error is located at:
    in RNHoleView (created by RNHoleView)
    in RNHoleView (created by react_native.core.pressable)
    in RCTView (created by View)
    in View (created by Pressable)
    in Pressable (created by Pressable)
    in react_native.core.pressable
    in quo.components.profile.profile_card.view.profile_card
    in status_im.contexts.profile.profiles.view.profile_card
    in RCTView (created by View)
    in View (created by CellRenderer)
    in VirtualizedListCellContextProvider (created by CellRenderer)
    in CellRenderer (created by VirtualizedList)
    in RCTView (created by View)
    in View (created by ScrollView)
    in RCTScrollView (created by ScrollView)
    in ScrollView (created by ScrollView)
    in ScrollView (created by VirtualizedList)
    in VirtualizedListContextProvider (created by VirtualizedList)
    in VirtualizedList (created by FlatList)
    in FlatList (created by react_native.flat_list.flat_list)
    in react_native.flat_list.flat_list
    in RCTView (created by View)
    in View (created by AnimatedComponent(View))
    in AnimatedComponent(View)
    in Unknown (created by react_native.reanimated.view)
    in react_native.reanimated.view
    in status_im.contexts.profile.profiles.view.profiles_section
    in status_im.contexts.profile.profiles.view.view
    in RCTView (created by View)
    in View (created by quo.theme.provider)
    in quo.theme.provider
    in reagent8 (created by gestureHandlerRootHOC(reagent8))
    in RNGestureHandlerRootView (created by GestureHandlerRootView)
    in GestureHandlerRootView (created by gestureHandlerRootHOC(reagent8))
    in gestureHandlerRootHOC(reagent8) (created by WrappedComponent)
    in WrappedComponent
    in RCTView (created by View)
    in View (created by AppContainer)
    in RCTView (created by View)
    in View (created by AppContainer)
    in AppContainer
    in profile.profiles(RootComponent), js engine: hermes

The root cause could probably be float to int conversion here -> https://github.com/ibitcy/react-native-hole-view/blob/b4b60b508cb43ce739eeb3f2abede491d21155af/android/src/main/java/com/ibitcy/react_native_hole_view/RNHoleView.kt#L80-L177

A simple fix could be to try-catch the exceptions first and if possible fix it or maybe even mute it.

The number 371.42857142857144 was the width of the device and react-native-hole-view was unable to deal with animating floating point numbers. A simpler fix was to round off width on cljs side before passing it to hole-view/hole-view component.

@status-im/mobile-qa : this fixes issue 1
PR is ready for testing.

@status-im/mobile-qa : this fixes issue 1
PR is ready for testing.

Hey @siddarthkay! Unfortunately ISSUE 1 is still reproducible for me in the latest PR build

Status-debug-logs - 2024-09-16T123354.319.zip

Hi @pavloburykh : Thanks for checking! I'll try to reproduce again and fix 🙏🏻

ISSUE 3 Bottom sheets are closed by itself after being opened within 'Profiles on device' screen

Steps:

1. Open 'Profiles on device' screen
2. Tap '+' or '...' buttons
3. Observe the behaviour of the bottomsheets

Actual result: Bottom sheets are closed by itself after being opened

ISSUE 4 Broken layout of Create Profile screen when creating additional profile from 'Profiles on device' screen

Steps:

1. Open 'Profiles on device' screen
2. Create new profile screen
3. Observe broken layout

Actual result:

Hey @siddarthkay ! I have moved PR moved Contributor column. Please feel free to ping me and move PR back to In Testing once issues are resolved. Thank you.