Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectibles list contains unsupported images (when they have images on OpenSea) #19816

Open
mariia-skrypnyk opened this issue Apr 26, 2024 · 9 comments
Labels
blocked bug medium-prio wallet: Collectibles all issues for the collectibles page of the wallet wallet-core Issues for mobile wallet team

Comments

@mariia-skrypnyk
Copy link

mariia-skrypnyk commented Apr 26, 2024

Bug Report

#19528 (comment)
was discussed here

Problem

Sometimes we can see Unsupported files in Collectibles list
Screenshot 2024-04-26 at 14 36 58

Expected behavior

I suppose we need to handle more image types (probably the most popular one's)

Actual behavior

Collectibles list contains unsupported images

Reproduction

  1. Login to app with a User who has a big number of collectibles
  2. Open Wallet -> Collectibles tab
  3. Starts to scroll your collectibles

Additional Information

  • Status version: nightly 25/04
  • Operating System: Android, iOS
@FFFra
Copy link
Contributor

FFFra commented May 6, 2024

Maybe this is duplicated? #18527

@FFFra FFFra removed their assignment May 8, 2024
@J-Son89
Copy link
Contributor

J-Son89 commented May 9, 2024

@mariia-skrypnyk - this is expected to have in the designs. Are you aware of any particular formats that are missing at the moment in which we should include?

@mariia-skrypnyk
Copy link
Author

@mariia-skrypnyk - this is expected to have in the designs. Are you aware of any particular formats that are missing at the moment in which we should include?

Hi @J-Son89 !

No, I do not have any particular format to share now. But I can keep it in mind and update the information here in case I find it.

@J-Son89 J-Son89 added the wallet-core Issues for mobile wallet team label Jun 14, 2024
@churik churik changed the title Collectibles list contains unsupported images Collectibles list contains unsupported images (when they have images on OpenSea Jun 24, 2024
@churik churik changed the title Collectibles list contains unsupported images (when they have images on OpenSea Collectibles list contains unsupported images (when they have images on OpenSea) Jun 24, 2024
@churik
Copy link
Member

churik commented Jun 24, 2024

An interesting thing is that I can see the image on Opensea, for example:
https://opensea.io/assets/ethereum/0x3ca5b00ade54365fbd590d4bc397e044a13068e5/4346

FILE.2024-06-24.13.34.12.mp4

I'm not certain though about how we are retrieving images, so seems unexpected to me to have discrepancies with OpenSea on the matter.

@churik
Copy link
Member

churik commented Jun 24, 2024

increasing priority of this, as even very popular collectibles (i.e. ENS) don't have a picture, and display a fallback icon
IMAGE 2024-06-24 14:06:17

@churik
Copy link
Member

churik commented Jun 24, 2024

cross-reference #19950

@churik churik added the wallet: Collectibles all issues for the collectibles page of the wallet label Aug 29, 2024
@churik churik added this to the 2.31.0 Beta milestone Aug 29, 2024
@vkjr vkjr self-assigned this Sep 9, 2024
@vkjr
Copy link
Contributor

vkjr commented Sep 23, 2024

Unassigning because priorities for collectibles aren't clear yet and it is not fast to fix because issue has roots in status-go. We will have metrics for collectibles soon (#21279), that will make priorities more clear.

@vkjr vkjr removed their assignment Sep 23, 2024
@ulisesmac
Copy link
Contributor

@churik

I'm not certain though about how we are retrieving images, so seems unexpected to me to have discrepancies with OpenSea on the matter.

Some context about it.

Some OpenSea's images are SVGs or animated SVGs, which we don't support because they slowed down the app significantly.

Right now, we aren't even supporting GIF, they were removed on:

We talked about generating a fixed preview when we fetched the collectibles, but it needs some research.

Once we clarify the collectible priorities, as @vkjr said, we can solve it.

I'd suggest removing it from the 2.31 board.

CC: @shivekkhurana

@churik churik removed this from the 2.31.0 Beta milestone Oct 7, 2024
@churik
Copy link
Member

churik commented Oct 7, 2024

Thanks, removed.
Then I put blocked on this bug, since we're trying to understand the real usage of collectibles

@churik churik added the blocked label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug medium-prio wallet: Collectibles all issues for the collectibles page of the wallet wallet-core Issues for mobile wallet team
Projects
Status: Backlog
Development

No branches or pull requests

6 participants