Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to define pipelines with dependencies on post-process or output phases #237

Open
daveaglick opened this issue Apr 28, 2022 · 0 comments
Labels
Discussion/Question Discussions or questions about the code General Enhancement New feature or request

Comments

@daveaglick
Copy link
Member

Basically we need deployment pipelines, but for processing stuff so they always still come before deployment. Use case is something like a pipeline that processes the final HTML as rendered by Razor from other modules post-process phase and then writes an extra file to disk as a result. This needs to be able to

  1. run after other modules like content have completed their post-process phase
  2. read the output documents from the post-process phase (non-deployment pipelines are only allowed to read output documents from their own previous phases and other pipeline process phases)
  3. run before other deployment pipelines since it's not really a deployment pipeline in spirit

One thought was that to accomplish this today in an extensible generic way would be to register the pipeline as a deployment pipeline, then later (in an event or something) crawl through all registered pipelines in the engine and set DependencyOf in the pipeline in question to all the other dependency pipelines. That would grant it dependency pipeline functionality like 1) and 2) above while making all other dependency pipelines dependent on it to satisfy 3) above. Except I don't actually think that would work because the dependency chains are all about the process phase and still wouldn't prevent other deployment pipelines from executing their output phase before this one got a chance to write files in its own output phase.

A new mechanism might be needed here, or perhaps some changes to how dependencies work.

cc @phil-scott-78

@daveaglick daveaglick added General Enhancement New feature or request Discussion/Question Discussions or questions about the code labels Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion/Question Discussions or questions about the code General Enhancement New feature or request
Development

No branches or pull requests

1 participant