Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add knip to CI checks #4982

Closed
2 of 3 tasks
with-heart opened this issue Jul 15, 2024 · 0 comments · Fixed by #5030
Closed
2 of 3 tasks

Add knip to CI checks #4982

with-heart opened this issue Jul 15, 2024 · 0 comments · Fixed by #5030

Comments

@with-heart
Copy link
Contributor

with-heart commented Jul 15, 2024 •
edited
Loading

can this be added as a CI check?

Originally posted by @Andarist in #4974 (comment)

In order for this to happen, we first need to:

  • resolve "Referenced optional peerDependencies" warnings (not sure why these are reported)
  • resolve "Unlisted binaries" warnings (svelte-check and docs:build references in actions/workflows)
    • svelte-check is a dep of xstate-svelte so I think that might be why it errors
  • add action for knip to ci-checks/action.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add knip to ci-checks with-heart/xstate
1 participant
@with-heart