Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loo_moment_match p_loo computation #257

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

avehtari
Copy link
Collaborator

@avehtari avehtari commented Mar 4, 2024

fixes #256, by computing the lpd with the original parameters (instead of moment matched parameters)
updated also the test reference results

@avehtari avehtari requested a review from jgabry March 4, 2024 13:49
@jgabry jgabry merged commit bb3abb2 into master Mar 5, 2024
6 checks passed
@jgabry jgabry deleted the fix_loo_moment_matching_p_loo branch March 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loo_moment_match_i computes wrong p_loo
2 participants