Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R2 #201

Open
sims1253 opened this issue May 10, 2022 · 6 comments
Open

Add R2 #201

sims1253 opened this issue May 10, 2022 · 6 comments

Comments

@sims1253
Copy link

It would be nice if the loo objects weren't hardcoded to use elpd. For a study I wanted to include rmse and R2 and had to build fake loo objects in order to use the loo_compare functionality. Code is here.

@avehtari
Copy link
Collaborator

I had missed this issue
Thanks for the code!
PRs #202 and #203 are adding more utilities/losses, but we still need to add options for loo_compare to know which utility/loss to use
brms part of the code needs to go to brms package

@avehtari avehtari mentioned this issue Nov 16, 2022
@avehtari
Copy link
Collaborator

@sims1253 do you need something else than what is in the PRs mentioned above, or can we close this issue?

@avehtari avehtari changed the title Allow use of other criteria Add R2 Nov 29, 2023
@avehtari
Copy link
Collaborator

We do have rmse, but we're still missing R2 (which is available in brms and rstanarm, but not as plain loo package version)

@sims1253
Copy link
Author

...which is available in brms

At least the brms version does not use psis, which is why I wrote the version from my pr.

@avehtari
Copy link
Collaborator

@sims1253
Copy link
Author

True. Sorry, I'm currently on vacation and only have my phone and only found the Bayes r2 function.
Maybe it was about the pointwise estimate for the SE then that we built the new version. I don't quite remember to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants