Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Test For GetFeaturePhaseByUUID #1835

Closed
4 tasks
elraphty opened this issue Jul 3, 2024 · 3 comments · Fixed by #1841
Closed
4 tasks

Write Test For GetFeaturePhaseByUUID #1835

elraphty opened this issue Jul 3, 2024 · 3 comments · Fixed by #1841
Assignees
Labels

Comments

@elraphty
Copy link
Contributor

elraphty commented Jul 3, 2024

Context

Currently, we do not have a test for GetFeaturePhaseByUUID

Design

We want to write the tests to use a real Postgres DB spun up on docker, follow the instructions in the Unit Testing section of README.md to run spin up a database in docker, and change the test_config.go configuration.

After spinning up the Postgres DB container:

  • Add this line of code on the first line and second of the test function TestGetFeaturePhaseByUUID to connect to the Test DB
    teardownSuite := SetupSuite(t)
    defer teardownSuite(t)

    fHandler := NewFeatureHandler(db.TestDb)

The test will throw a dereference error if not connected to a DB.

  • Create a person using the db.TestDb.CreateOrPerson() function e.g
person := db.Person{
     Uuid:        ${uuid},
     OwnerAlias:  ${alias},
     UniqueName:  ${unique_name},
     OwnerPubKey:  ${pubkey},
     PriceToMeet: 0,
     Description:  ${description},
}

db.TestDb.CreateOrEditPerson(person)
  • Create a workspace by using the db.TestDb.CreateOrEditWorkspace() function e.g
workspace := db.Workspace{
   Uuid:   ${workspace_uuid},
   Name:   ${workspace_name},
   OwnerPubKey:  ${person.OwnerPubkey},
   Github: ${gtihub},
   Website: ${website},
   Description: ${description},
}
db.TestDB.CreateOrEditWorkspace(workspace)
  • Get the workspace created by using workspace:= db.TestDb.GetWorkspaceByUuid(workspace.Uuid)
  • Create a workspace feature using the db.TestDb.CreateOrEditFeature(feature) function e.g
feature := db.WorkspaceFeatures {
	Uuid: ${uuid}
	WorkspaceUuid: workspace.UUid,
	Name: ${name},          
	Url: ${url},
        Priority: 0,         
}
db.TestDb.CreateOrEditFeature(feature)
  • Create a feature phase using the db.TestDb.CreateOrEditFeaturePhase(featurePhase) function e.g
featurePhase := db.FeaturePhase {
	Uuid: ${uuid}
	FeatureUuid: feature.UUid,
	Name: ${name},          
        Priority: 0,         
}
db.TestDb.CreateOrEditFeaturePhase(featurePhase)
  • Create a test route using r.Get("/{feature_uuid}/phase/{phase_uuid}", featureHandlers.GetFeaturePhaseByUUID) as a reference, the test route
  • Pass the created featurePhase Uuid as the URL parameter
  • Assert that it throws a 401 error if a user is not authorized
  • Assert that the feature phase created is what is returned from the API.

Assertions

  • Assert that the workspace features phases returned from the API is the feature phases created
  • Assert that all the test passes

Acceptance Criteria

  • I have rebased and tested locally before submitting my PR
  • I can submit a PR within 1 day of taking the bounty

Here is an example Real DB Test

@MahtabBukhari
Copy link
Contributor

MahtabBukhari commented Jul 3, 2024

@elraphty Could you please assign me?

@aliraza556
Copy link
Contributor

aliraza556 commented Jul 3, 2024

@elraphty Please assign me?

@elraphty
Copy link
Contributor Author

elraphty commented Jul 3, 2024

@elraphty Please assign me?

@aliraza556 you get next one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants