Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune Expired Invoices From Invoice List #1679

Closed
4 tasks
elraphty opened this issue Jun 3, 2024 · 0 comments · Fixed by #1681
Closed
4 tasks

Prune Expired Invoices From Invoice List #1679

elraphty opened this issue Jun 3, 2024 · 0 comments · Fixed by #1681
Assignees
Labels

Comments

@elraphty
Copy link
Contributor

elraphty commented Jun 3, 2024

Context

Currently, we save all the invoice payment requests of invoices generated by swarm4 on the invoice_lists table and check to see if the invoice is settled so we can change the status.

Design

We want to delete every expired invoice from the invoice_list table that has not been paid, so when we poll for a workspace's invoices, we check the expiration time of the invoice, if an invoice has expired and the invoice has not been paid we will delete the invoice from the invoice_list table.

Acceptance Criteria

  • I've tested on Chrome
  • I've created a test that...
  • I have rebased and tested locally before submitting my PR
  • I can submit a PR within 2 days of taking the bounty

Here is an example backend test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant