Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Features endpoint and add delete feature #1639

Closed
3 tasks
fvalentiner opened this issue May 12, 2024 · 11 comments
Closed
3 tasks

Modify Features endpoint and add delete feature #1639

fvalentiner opened this issue May 12, 2024 · 11 comments
Assignees
Labels

Comments

@fvalentiner
Copy link
Contributor

fvalentiner commented May 12, 2024

Context

Step 1
Modify the endpoint url from

/features/forworkspace/{workspace_uuid}

to

workspaces/{workspace_uuid}/features

Step 2
Add endpoint for DELETE /features

Design

  1. clone branch
    https://github.com/stakwork/sphinx-tribes/tree/feature-add-features-to-workspaces-modify-delete

  2. Make sure you are running posgresql locally

  3. Create file .env with the following content
    PORT=5005
    DATABASE_URL=postgres://postgres:asdf@localhost:5432/ebdb?sslmode=disable

Change DATABASE_URL to connect to your local DB (it could be an empty db)
4. Run "go run ." to run the backend API that connects to the DB and creates the objects
5. Open a new terminal window and run "npx cypress run" this starts to run the tests
image

Your job is to create the routes, handler functions and db changes in order for the test to pass. If you find any issues or typos in the cypress tests please let the creator of the issue know.

Before committing your changes make sure the cypress tests pass.

Acceptance Criteria

  • Tests are passing using "npx cypress run"
  • I have rebased and tested locally before submitting my PR
  • I can submit a pr within 2 days of taking the bounty

The bounty for this is: https://community.sphinx.chat/bounty/1926

@jordan-ae
Copy link
Contributor

I can help

@fvalentiner
Copy link
Contributor Author

I can help

Great! What's you user here? https://community.sphinx.chat/p

@fvalentiner
Copy link
Contributor Author

@jordan-ae

@jordan-ae
Copy link
Contributor

@fvalentiner its Mandela on Sphinx

@MirzaHanan
Copy link
Contributor

Hi @fvalentiner,
may I handle this task if @jordan-ae doesn't wish to work on it?

@MahtabBukhari
Copy link
Contributor

Hi @jordan-ae are you working on this task?
@fvalentiner if @jordan-ae working on it then its great otherwise I am awailable for this task as i have no any other task.

@MahtabBukhari
Copy link
Contributor

@fvalentiner Could i take this one if @jordan-ae not want to continue with that?

This was referenced May 16, 2024
@MahtabBukhari
Copy link
Contributor

Hi @fvalentiner @elraphty Could you please confirm is this enpoint is in used at frontend side
image

Becuase Cypress tests are going to be pass only this endpoint as I change the url cypress tests are going to be failed.

@MahtabBukhari
Copy link
Contributor

@fvalentiner @elraphty Could you please update from frontend side becuase this endpoint is used at frontend side due to which when i change this url then cypress are going to be failed "/features/forworkspace/{workspace_uuid}"

@fvalentiner
Copy link
Contributor Author

@MahtabBukhari leave the old endpoint for now

@MahtabBukhari
Copy link
Contributor

MahtabBukhari commented May 20, 2024

@fvalentiner I have implemented the new endpoint and old one is also present.
The benefit is that when we update the url from front-end then no cypress issue Will accor and we can delete the old endpoint when needed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants