Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Handle requests that do not have a response exactly once #587

Open
3 tasks
djordon opened this issue Sep 30, 2024 · 0 comments
Open
3 tasks

[Feature]: Handle requests that do not have a response exactly once #587

djordon opened this issue Sep 30, 2024 · 0 comments
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Contributor

djordon commented Sep 30, 2024

Feature - Handle requests that do not have a response exactly once

1. Description

When we reach out to the Emily API for deposit requests, we end up adding it to our list of deposits-to-watch-for each time. And every time there is a new bitcoin block we attempt to process "pending" deposits but our queries do not distinguish between deposits that do or do not have a response. This causes us to continually include deposit UTXOs in our bitcoin transactions.

1.1 Context & Purpose

When we get a request from Emily, make sure that it is added to our list of deposits-to-watch-for at most once. Update our queries to exclude deposit requests that have a response transaction that has been confirmed.

2. Technical Details:

2.1 Acceptance Criteria:

  • The signers' deposits-to-watch-for list never contains duplicates.
  • The signers never construct a response transaction for a deposit request if they have responded already and it is confirmed on the canonical bitcoin blockchain.
  • We attempt to vote on a deposit or withdrawal request once.

3. Related Issues and Pull Requests (optional):

@djordon djordon added the sbtc bootstrap signer The sBTC Bootstrap Signer. label Sep 30, 2024
@djordon djordon added this to the sBTC MVP Code Complete milestone Sep 30, 2024
@djordon djordon changed the title [Feature]: Handle deposit requests that do not have a response exactly once [Feature]: Handle requests that do not have a response exactly once Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.
Projects
None yet
Development

No branches or pull requests

1 participant