Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow for the blocklist client to be unset #586

Open
1 task
djordon opened this issue Sep 30, 2024 · 0 comments · May be fixed by #589
Open
1 task

[Feature]: Allow for the blocklist client to be unset #586

djordon opened this issue Sep 30, 2024 · 0 comments · May be fixed by #589
Assignees
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Contributor

djordon commented Sep 30, 2024

Feature - Allow for the blocklist client to be unset

1. Description

We don't need a blocklist client, and someone can choose to run their signer without one. In this case, the signer should still run correctly and we should skip the code path that does blocklist checks.

1.1 Context & Purpose

2. Technical Details:

Make the blocklist config optional and have the SignerContext object optionally return a blocklist client. When there isn't a config for the blocklist client, have an warn log and have all can_accept calls to the blocklist client return Ok(true) (or whatever would be equivalent).

2.1 Acceptance Criteria:

  • Allow for the blocklist client to be unset in the config.

3. Related Issues and Pull Requests (optional):

@djordon djordon added the sbtc bootstrap signer The sBTC Bootstrap Signer. label Sep 30, 2024
@djordon djordon added this to the sBTC Release Ready milestone Sep 30, 2024
@djordon djordon self-assigned this Oct 1, 2024
@djordon djordon linked a pull request Oct 1, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant