Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Validate message to sign in transaction signer #296

Open
netrome opened this issue Jul 5, 2024 · 1 comment
Open

[Feature]: Validate message to sign in transaction signer #296

netrome opened this issue Jul 5, 2024 · 1 comment
Labels
good first issue Good for newcomers sbtc bootstrap signer The sBTC Bootstrap Signer.

Comments

@netrome
Copy link
Contributor

netrome commented Jul 5, 2024

Context

In #294, support for participating in WSTS signing rounds was implemented for the transaction signer. However, in this implementation, the transaction signer happily signs any message received from the coordinator. To ensure the signer doesn't sign any malicious message, it should ensure that the requested message is indeed the appropriate sighash for the given transaction.

Definition of done

The transaction signer only participates in signing rounds for valid messages.

@djordon
Copy link
Contributor

djordon commented Sep 27, 2024

This ticket, #578, adds more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers sbtc bootstrap signer The sBTC Bootstrap Signer.
Projects
None yet
Development

No branches or pull requests

4 participants